tests: fix top online warning in TestAcctUpdatesCachesInitialization #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Aug 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #4451 +/- ##
==========================================
+ Coverage 51.51% 55.23% +3.72%
==========================================
Files 398 398
Lines 50165 50165
==========================================
+ Hits 25841 27710 +1869
+ Misses 21934 20144 -1790
+ Partials 2390 2311 -79
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestAcctUpdatesCachesInitialization generates online/offline deltas and sets VoteLastValid=1000.
Since the tests goes beyond 1000 rounds, most of the accounts became expired for stateproof and TopOnlineAccounts renders a warning.
Test Plan
This is a test